Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ステータスコードのチェック #1274

Merged
merged 7 commits into from
Oct 17, 2024
Merged

ステータスコードのチェック #1274

merged 7 commits into from
Oct 17, 2024

Conversation

kavos113
Copy link

#1270
変更箇所

  • POST /questionnaires
    • 201を返すように
  • GET /questionnaires/{questionnaireID}, GET /questionnaires/{questionnaireID}/responses, GET /questionnaires/{questionnaireID}/result
    • 404を返すように
  • GET PATCH DELETE /responses/{responseID}
    • 404, 405を返すように

あと，正規表現を使わなくなったのでopenapiで定義されている GET /questionnaires の503エラーは必要ないと思われます

@kavos113 kavos113 requested a review from kaitoyama October 14, 2024 04:33
@kaitoyama
Copy link
Contributor

これって、基本swaggerに揃えたという認識で良いですか？

@kavos113
Copy link
Author

はい、swagger通りに買えるように修正しました

kaitoyama
kaitoyama approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

@kavos113 kavos113 merged commit a69191b into fix/openapi Oct 17, 2024
4 of 7 checks passed
@kavos113 kavos113 deleted the fix/openapi-statuscode branch October 17, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitoyama kaitoyama kaitoyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavos113 @kaitoyama